Repository navigation
feat(sync): sync Hive ADRs 0018–0024 to the docs site - #360
Conversation
Add the ADRs that exist on hivecommons/hive v5 after 0017 to the sync list so they are hosted under /docs/hive/adr/ instead of linking out to GitHub. v5 has no ADR 0021 and ADR 0020 is named 0020-spek-continuous-convergence.md, so the list is the six real files. Hive-Run: hivecommons#358 Hive-Plan: add missing ADR entries to sync-hive-docs.ts Hive-Spec: sync-hive-docs#adr-list Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Lv7WuWSM3PssHEeaQoyjZT Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
👷 Deploy request for hivecommons-docs pending review.Visit the deploys page to approve it
|
There was a problem hiding this comment.
This is now a byte-for-byte duplicate of #359 — a maintainer needs to pick one; I have not closed anything.
What I verified (read both diffs in full and the v5 tree of hivecommons/hive/src/docs/adr/):
- Both PRs change the same three files with identical hunks:
scripts/sync-hive-docs.ts:78-83(adds 0018, 0019,0020-spek-continuous-convergence.md, 0022, 0023, 0024),scripts/sync-hive-docs.main.test.ts:68(completion sentinel moved toadr/0024-provider-credential-lifecycle.md), and the samechangelog.d/added-358-sync-adr-0018-0024.md. - The six filenames match the
v5directory listing exactly; there is no0021onv5, andsync-hive-docs.ts:15defaultsHIVE_DOCS_REFtov5, so every added source resolves. The correction this PR's body describes is right. - Timeline: #359 opened 21:17Z with the wrong 0020 name and a nonexistent 0021 (the 404 this body mentions). This PR opened 21:26Z with the correct list. #359 then pushed
5780ad5at 21:31Z adopting the identical fix, so the body's "#359's Build check fails" is no longer true — both are green.
Both close #358; only one can merge. #359 is earlier and on the trusted automerge lane; this PR is the one that actually identified the filename error first. That's a credit/ownership choice, not a code one.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
hive/awaiting-ci: #359 closed in favour of this PR as its body requested — the diffs were identical and this one got the ADR list right first. CI is green; this is now the sole PR for #358 and merges after maintainer review. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
|
Needs a decision, not a merge:
Head: verdict requires_human @dcc9dfe, 5/5 checks green, DCO yes, soak 12m0s of 30m0s. Clear the cause and the hive re-evaluates on its next pass; the stage moves to |
|
Hive filed review findings that do not block this PR as backlog items:
Cap: 10 backlog item(s) per PR per day. |
|
Verified against the current /lgtm |
|
LGTM label has been added. DetailsGit tree hash: 2b54607110901a4c5b2bcaca2ce284243da56e8d |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clubanderson The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes #358
Adds the ADRs that exist on hivecommons/hive
v5after 0017 to the sync list inscripts/sync-hive-docs.ts, so they are hosted at/docs/hive/adr/…like 0001–0017.Differs from the issue's list (and from #359, whose Build check fails with a 404 on
0020-external-work-source-boundary.md): onv5, ADR 0020 is0020-spek-continuous-convergence.mdand there is no ADR 0021. Verified with thev5tree listing ofsrc/docs/adr/. This PR therefore lists 0018, 0019, 0020, 0022, 0023 and 0024. #359 can be closed in favour of this one.Tests:
vitest run scripts/sync-hive-docsand changelog fragment tests pass; prettier and markdownlint clean. Includes thechangelog.dfragment.🤖 Generated with Claude Code
https://claude.ai/code/session_01Lv7WuWSM3PssHEeaQoyjZT
— hive: backend=claude